RFR: JDK-8301378: CodeHeap has virtual methods that are not overridden

Tobias Hartmann thartmann at openjdk.org
Tue Jan 31 06:38:04 UTC 2023


On Mon, 30 Jan 2023 18:24:52 GMT, Justin King <jcking at openjdk.org> wrote:

> Remove unused `virtual` specifiers on `CodeHeap` methods. Virtual dispatch is not free in C++ and usually incurs a vtable lookup unless the compiler can prove the type is final, which with the current setup is not feasible.

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12298


More information about the hotspot-runtime-dev mailing list