RFR: JDK-8301378: CodeHeap has virtual methods that are not overridden

Tue Jan 31 08:10:07 UTC 2023

On Mon, 30 Jan 2023 18:24:52 GMT, Justin King <jcking at openjdk.org> wrote:

> Remove unused `virtual` specifiers on `CodeHeap` methods. Virtual dispatch is not free in C++ and usually incurs a vtable lookup unless the compiler can prove the type is final, which with the current setup is not feasible.

Unfortunately, this caused massive failures with the SA tests and we therefore had to back the change out (see [JDK-8301448](https://bugs.openjdk.org/browse/JDK-8301448)). @jcking please enable testing via Github actions, see https://openjdk.org/guide/#github-actions.

-------------

PR: https://git.openjdk.org/jdk/pull/12298