RFR: 8301095: [s390x] TestDwarf.java fails [v2]

Lutz Schmidt lucy at openjdk.org
Tue Jan 31 15:48:30 UTC 2023


On Tue, 31 Jan 2023 07:02:26 GMT, Amit Kumar <duke at openjdk.org> wrote:

>> TestDwarf.java fails on s390 due to incorrect returned frame. for dereference_null crash, the (return) pc was selected from gpr14 (in accordance with z-ABI) but correct (return) pc was present at "return_pc" offset. This PR introduces an additional check for the frame type detection. 
>> Special Thanks to @RealLucy
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   no need to fetch sender_sp again

Changes requested by lucy (Reviewer).

src/hotspot/os_cpu/linux_s390/os_linux_s390.cpp line 175:

> 173:       }
> 174:     } else {
> 175:       return frame(fr->sender_sp(), fr->native_sender_pc());

We use 2-space indentation for c/cpp files.

src/hotspot/os_cpu/linux_s390/os_linux_s390.cpp line 177:

> 175:         intptr_t* sender_sp = fr->sender_sp();
> 176:         address   sender_fp = (address)*sender_sp;
> 177:         ptrdiff_t entery_len = sender_fp - (address)sender_sp;

I guess this should read "entry_len".

-------------

PR: https://git.openjdk.org/jdk/pull/12306


More information about the hotspot-runtime-dev mailing list