RFR: 8311145: Remove check_with_errno duplicates
Thomas Stuefe
stuefe at openjdk.org
Sat Jul 1 07:44:54 UTC 2023
On Sat, 1 Jul 2023 01:08:42 GMT, Daohan Qu <dqu at openjdk.org> wrote:
>> This trivial patch moves the same macros to a common header file.
>
> Oh, I see.
> @quadhier hotspot changes use two reviewers, one with capital R (i.e. reviewer status on census) and a second reviewer (which may be e.g. a comitter).
>
> You find the info here: https://openjdk.org/guide/#contributing-to-an-openjdk-project "At least one reviewer should be knowledgeable in the area being changed. Some areas (e.g. client and hotspot) require two reviewers in most cases, so be sure to read the relevant OpenJDK group pages for advice or ask your sponsor."
>
> @tstuefe is this what you had in mind?
Sounds right. Did I write that?
> > @quadhier hotspot changes use two reviewers, one with capital R (i.e. reviewer status on census) and a second reviewer (which may be e.g. a comitter).
> > You find the info here: https://openjdk.org/guide/#contributing-to-an-openjdk-project "At least one reviewer should be knowledgeable in the area being changed. Some areas (e.g. client and hotspot) require two reviewers in most cases, so be sure to read the relevant OpenJDK group pages for advice or ask your sponsor."
> > @tstuefe is this what you had in mind?
>
> Sounds right. Did I write that?
Oh, you mean the patch, not the Wiki :-) Still too early here.
Patch looks fine. Thanks for doing this.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14733#issuecomment-1615601279
PR Comment: https://git.openjdk.org/jdk/pull/14733#issuecomment-1615601739
More information about the hotspot-runtime-dev
mailing list