RFR: 8311145: Remove check_with_errno duplicates

Thomas Stuefe stuefe at openjdk.org
Sat Jul 1 08:23:54 UTC 2023


On Sat, 1 Jul 2023 07:41:27 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Oh, I see.
>
>> > @quadhier hotspot changes use two reviewers, one with capital R (i.e. reviewer status on census) and a second reviewer (which may be e.g. a comitter).
>> > You find the info here: https://openjdk.org/guide/#contributing-to-an-openjdk-project "At least one reviewer should be knowledgeable in the area being changed. Some areas (e.g. client and hotspot) require two reviewers in most cases, so be sure to read the relevant OpenJDK group pages for advice or ask your sponsor."
>> > @tstuefe is this what you had in mind?
>> 
>> Sounds right. Did I write that?
> 
> Oh, you mean the patch, not the Wiki :-) Still too early here.
> 
> Patch looks fine. Thanks for doing this.

> Thanks for your review, @tstuefe !

Sure. You need to integrate again, then I can sponsor.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14733#issuecomment-1615675362


More information about the hotspot-runtime-dev mailing list