RFR: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf [v3]

David Holmes dholmes at openjdk.org
Mon Jul 3 04:24:55 UTC 2023


On Mon, 3 Jul 2023 02:58:15 GMT, Vladimir Petko <duke at openjdk.org> wrote:

>> Changes:
>> - Add test exclusion for armhf, because os::current_frame() is not implemented
>> 
>> Testing:
>> 
>> 
>> AMD64:
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/hotspot/jtreg/runtime/jni/nativeStack/TestNativeStack.java
>>                                                          1     1     0     0   
>> ==============================
>> TEST SUCCESS
>> 
>> Stopping javac server
>> Finished building target 'test' in configuration 'linux-x86_64-server-release
>> 
>> ARMHF
>> 
>> Running test 'jtreg:test/hotspot/jtreg/runtime/jni/nativeStack/TestNativeStack.java'
>> Test results: no tests selected
>> Report written to /home/ubuntu/jdk/build/linux-arm-server-release/test-results/jtreg_test_hotspot_jtreg_runtime_jni_nativeStack_TestNativeStack_java/html/report.html
>> Results written to /home/ubuntu/jdk/build/linux-arm-server-release/test-support/jtreg_test_hotspot_jtreg_runtime_jni_nativeStack_TestNativeStack_java
>> Finished running test 'jtreg:test/hotspot/jtreg/runtime/jni/nativeStack/TestNativeStack.java'
>> Test report is stored in build/linux-arm-server-release/test-results/jtreg_test_hotspot_jtreg_runtime_jni_nativeStack_TestNativeStack_java
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/hotspot/jtreg/runtime/jni/nativeStack/TestNativeStack.java
>>                                                          0     0     0     0   
>> ==============================
>> TEST SUCCESS
>
> Vladimir Petko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   bump copyright year

Functional change is good, just need the copyright change adjusted.

Thanks

test/hotspot/jtreg/runtime/jni/nativeStack/TestNativeStack.java line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

Please change the copyright to read "2022, 2023," - thanks.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14750#pullrequestreview-1510322361
PR Review Comment: https://git.openjdk.org/jdk/pull/14750#discussion_r1250191814


More information about the hotspot-runtime-dev mailing list