RFR: 8310170: Use sp's argument to improve performance of outputStream::indent and remove SP_USE_TABS [v2]

[Thomas Stuefe]

On Tue, 4 Jul 2023 12:24:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> Please consider this small enhancement. `sp` takes a count argument, this was never used by `indent`, let's just use it.
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove SP_USE_TABS

Good.

src/hotspot/share/utilities/ostream.cpp line 190:

> 188: 
> 189: void outputStream::sp(int count) {
> 190:   if (count < 0)  return;

Is this  needed?

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14502#pullrequestreview-1512819743
PR Review Comment: https://git.openjdk.org/jdk/pull/14502#discussion_r1251984841