RFR: 8310170: Use sp's argument to improve performance of outputStream::indent and remove SP_USE_TABS [v2]

[David Holmes]

On Tue, 4 Jul 2023 12:24:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> Please consider this small enhancement. `sp` takes a count argument, this was never used by `indent`, let's just use it.
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove SP_USE_TABS

Looks good.

As an aside I was disappointed to discover that the indentation facility is far less useful than it might be. I had hoped you could set the indentation and then have all following log output indented, until you reset it. But indentation only happens when you explicitly call `indent()` so you can't call e.g. `val->print_on(stream)` and have the caller control indentation (without `print_on` directly supporting it).

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14502#pullrequestreview-1513566060