RFR: 8311291: Enable creation of NonInterleavingLogStream from LogTarget

Johan Sjölen jsjolen at openjdk.org
Fri Jul 7 09:33:56 UTC 2023


On Tue, 4 Jul 2023 12:54:12 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> This patch enables the same kind of construction method for NILS that we already have for regular LogStream. We need to do some ugly changes to make it work, but it's so much more ergonomic for usage sites that I think it's worth it.

src/hotspot/share/logging/log.hpp line 174:

> 172: 
> 173: // Combines logging tags and a logging level.
> 174: template <LogLevelType tmpl_level, LogTagType T0, LogTagType T1 = LogTag::__NO_TAG, LogTagType T2 = LogTag::__NO_TAG,

This change isn't needed, remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14769#discussion_r1255540095


More information about the hotspot-runtime-dev mailing list