RFR: 8311583: tableswitch broken by JDK-8310577 [v2]

[Dean Long]

On Fri, 7 Jul 2023 13:00:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I demoted some types for -Wconversion warnings but they're supposed to be larger types to catch overflow for tableswitch and lookupswitch.  Restored old code (except int64_t not jlong).
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   David's feedback.

Looks good except for jasm comment I suggest improving.

test/hotspot/jtreg/runtime/verifier/tableswitchp1.jasm line 35:

> 33:     bytecode 0x80,0,0,0; // 0x80000000 low
> 34:     bytecode 0x7F,0xFF,0xFF,0xFF; // 0x7fffffff high
> 35:     // no jump table, but gets past verifier

Suggestion:

    // illegal empty jump table

-------------

Marked as reviewed by dlong (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14788#pullrequestreview-1523253024
PR Review Comment: https://git.openjdk.org/jdk/pull/14788#discussion_r1259055660