RFR: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified [v3]

Doug Simon dnsimon at openjdk.org
Wed Jul 12 20:06:04 UTC 2023


On Wed, 12 Jul 2023 20:01:26 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> EnableJVMCI appends the jdk.internal.vm.ci module and disables full module graph. Temporarily bypasses FMG-related tests with EnableJVMCI until JDK-8266329 is resolved.
>
> Yudi Zheng has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified.
>  - Revert "Create numbered property for the JVMCI module only when non-default modules are specified."
>    
>    This reverts commit 0f2a6e414b79ed2ea096ed65e642f2b0ab5a4272.

Marked as reviewed by dnsimon (Committer).

test/hotspot/jtreg/runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java line 30:

> 28:  * @library /test/lib
> 29:  * @requires vm.cds.write.archived.java.heap
> 30:  * @requires !vm.jvmci.enabled

Please add a comment to https://bugs.openjdk.org/browse/JDK-8266329 to remove this guard as part of resolving the issue.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14485#pullrequestreview-1527143020
PR Review Comment: https://git.openjdk.org/jdk/pull/14485#discussion_r1261669664


More information about the hotspot-runtime-dev mailing list