RFR: 8311648: Refactor the Arena/Chunk/ChunkPool interface [v4]

Johan Sjölen jsjolen at openjdk.org
Thu Jul 13 15:24:17 UTC 2023


On Tue, 11 Jul 2023 19:55:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move stuff around to make diffs smaller
>
> src/hotspot/share/memory/arena.cpp line 214:
> 
>> 212: 
>> 213: Arena::Arena(MEMFLAGS flag) : _flags(flag), _size_in_bytes(0) {
>> 214:   _first = _chunk = ChunkPool::allocate_chunk(AllocFailStrategy::EXIT_OOM, Chunk::init_size);
> 
> I have one request - can you make the AllocFailStrategy the last parameter?

Fixed!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14803#discussion_r1262719705


More information about the hotspot-runtime-dev mailing list