RFR: JDK-8312182: THPs cause huge RSS due to thread start timing issue
Thomas Stuefe
stuefe at openjdk.org
Wed Jul 19 07:37:43 UTC 2023
On Wed, 19 Jul 2023 04:14:34 GMT, David Holmes <dholmes at openjdk.org> wrote:
> I think this would be better hidden in os::Linux::default_guard_size
I don't like this, since it would keep those two mitigations we apply - adding the glibc guard page and altering the stack size to be THP unaligned - separate in code. I find it clearer to have them in one place.
> and only applied to JavaThreads.
No, it makes sense to apply this to any thread that does not by-default run with a glibc guard page. But in practice, it is as you wish it to be since only Java Threads run without glibc guard pages.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14919#discussion_r1267663725
More information about the hotspot-runtime-dev
mailing list