RFR: 8312401: SymbolTable::do_add_if_needed hang when requesting length exceeds max_symbol_length

[David Holmes]

On Wed, 19 Jul 2023 20:18:01 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

> Please review the simple fix to resolve infinite loop in SymbolTable::do_add_if_needed caused by extra long symbol string that exceeds Symbol::max_length(). See JDK-8312401 for details.
> 
> The jtreg test is converted from a test case constructed by @cushon.

I'm not sure silently ignoring this by returning null is the right thing to do. Shouldn't we just truncate the message in this case?

Or are we even doing the wrong thing by returning as a Symbol in the first place? By doing so we seem to impose an artificial VM limit on the exception message length.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14938#pullrequestreview-1538432466