RFR: 8293972: runtime/NMT/NMTInitializationTest.java#default_long-off failed with "Suspiciously long bucket chains in lookup table." [v4]

[David Holmes]

On Thu, 20 Jul 2023 07:12:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - init NMT earlier to decrease the reliance on NMTPreInit lookup table, which lets us simplify the code
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8293972
>>  - do not clip bits to 32, we need full 64 bits
>>  - ^ is XOR, not pow
>>  - remove tabs
>>  - mark output with PID to help identify where it comes from
>>  - use Mersenne prime and mod for uniform bit distribution of hash
>
> src/hotspot/share/runtime/threads.cpp line 458:
> 
>> 456:   if (parse_result != JNI_OK) return parse_result;
>> 457: 
>> 458:   // Verify NMT flag(s) and log the initial state to the ouput
> 
> Nit: So far in this PR you have used the terms "NMT property", "NMT setting", "NMT arguments", and now "NMT flag(s)". Please pick one (not "property") and use consistently.

Typo: ouput

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14607#discussion_r1269030480