RFR: JDK-8312182: THPs cause huge RSS due to thread start timing issue [v3]

[Thomas Stuefe]

On Thu, 20 Jul 2023 14:20:49 GMT, Poonam Bajaj <poonam at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - test changes
>>  - Feedback David
>
> src/hotspot/os/linux/os_linux.cpp line 919:
> 
>> 917:   size_t guard_size = os::Linux::default_guard_size(thr_type);
>> 918: 
>> 919:   if (!DisableTHPStackMitigation) {
> 
> Shouldn't this block be right before calling pthread_attr_setstacksize() and after we have adjusted the stack size and have calculated the final stack_size value?

Good catch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14919#discussion_r1269552171