RFR: JDK-8305507 Add support for grace period before AbortVMOnSafepointTimeout triggers [v3]

[Patricio Chilano Mateo]

On Tue, 4 Jul 2023 08:42:16 GMT, Wojciech Kudla <duke at openjdk.org> wrote:

>> As described https://bugs.openjdk.org/browse/JDK-8305507 this change adds a grace period before AbortVMOnSafepointTimeout activates to allow for JVM warm-up to conclude
>
> Wojciech Kudla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update full name

Looks good.

test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java line 123:

> 121:             WhiteBox wb = WhiteBox.getWhiteBox();
> 122:             // induce a stall that should not be picked up before grace period
> 123:             wb.waitUnsafe(999);

So if we reach this line after 500ms from the time we set the initial counter in os::init() we will trigger the abort here instead. I measured that time just to check how close we are and in my testing machine I see we get here at about 130ms so probably is good enough, but maybe we should add 1 second to AbortVMOnSafepointTimeoutDelay just to be safe?

-------------

Marked as reviewed by pchilanomate (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13386#pullrequestreview-1541360315
PR Review Comment: https://git.openjdk.org/jdk/pull/13386#discussion_r1270801927