RFR: 8312401: SymbolTable::do_add_if_needed hang when requesting length exceeds max_symbol_length [v2]

[Jiangli Zhou]

On Mon, 24 Jul 2023 13:06:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update according to David Holmes' comments.
>>   - In java_lang_String::as_symbol and java_lang_String::as_symbol_or_null, check input string length and truncate to max symbol length if exceeding.
>>   - Change java_lang_Throwable::create_initialization_error to avoid using Symbol for message.
>
> I think just the javaClasses.cpp and the test should be enough to fix this bug.  Thank you for fixing it.

@coleenp @dholmes-ora Please take another look of the PR. I've reverted the java_lang_String::as_symbol change that truncates the string if length exceeds max symbol length, per our discussions in this thread. The PR now only addresses the issue with java_lang_Throwable::create_initialization_error. The other usages of java_lang_Throwable::detail_message can be followed up with https://bugs.openjdk.org/browse/JDK-8312616.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14938#issuecomment-1648466266