RFR: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) [v2]

Tyler Steele tsteele at openjdk.org
Tue Jul 25 14:27:22 UTC 2023


On Fri, 21 Jul 2023 18:28:34 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Tyler Steele has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>> 
>>  - Removes include unistd & replaces it with util/globalDefs.hpp
>>  - Replace os::vm_page_size call with sysconf(_SC_PAGESIZE) on AIX in javaClasses.cpp
>
> src/hotspot/share/classfile/javaClasses.cpp line 98:
> 
>> 96: #ifdef AIX
>> 97: #include <unistd.h>
>> 98: #endif
> 
> This should be part of utilities/globalDefinitions.hpp. Most of the standard headers are. So maybe just include that instead, then you don't need the ifdef AIX.

Made this change. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14963#discussion_r1273625810


More information about the hotspot-runtime-dev mailing list