RFR: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) [v2]

[Thomas Stuefe]

On Tue, 25 Jul 2023 14:22:14 GMT, Tyler Steele <tsteele at openjdk.org> wrote:

>> This change is as an alternate solution to my original proposal for [JDK-8312180](https://bugs.openjdk.org/browse/JDK-8312180).
>> 
>> Suggested by @tstuefe.
>> 
>> This change matches the return value of Bits.pageSize with the system page size (which is not currently true on AIX).
>> 
>> These tests are upstream of my target test (TestByteBuffer) and results are encouraging. Tier1 testing in ongoing for this change.
>
> Tyler Steele has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
> 
>  - Removes include unistd & replaces it with util/globalDefs.hpp
>  - Replace os::vm_page_size call with sysconf(_SC_PAGESIZE) on AIX in javaClasses.cpp

src/hotspot/share/classfile/javaClasses.cpp line 98:

> 96: #ifdef AIX
> 97: #include <unistd.h>
> 98: #endif

This should be part of utilities/globalDefinitions.hpp. Most of the standard headers are. So maybe just include that instead, then you don't need the ifdef AIX.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14963#discussion_r1270969268