RFR: JDK-8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v2]

Thomas Stuefe stuefe at openjdk.org
Wed Jul 26 09:13:12 UTC 2023


On Wed, 26 Jul 2023 06:03:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert part of logging
>
> Seems reasonable. Not 100% sure about the extra logging ... one query in relation to that.
> 
> Thanks.

@dholmes-ora : I removed parts of the logging. I went down a small rabbit hole about extending to /etc/ld.preload, about unifying that code with existing ld_preload printing, about security concerns (maybe we should obfuscate the values when logging), then I gave up and just removed it, since it does not directly relate to the patch at hand.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14984#issuecomment-1651300028


More information about the hotspot-runtime-dev mailing list