RFR: 8309240: Array classes should be stored in dynamic CDS archive [v2]

[Calvin Cheung]

On Wed, 26 Jul 2023 01:14:30 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simplify the fix
>
> src/hotspot/share/cds/archiveBuilder.cpp line 237:
> 
>> 235:   iterate_roots(&doit);
>> 236:   if (DynamicDumpSharedSpaces) {
>> 237:     iterate_primitive_array_klasses(&doit);
> 
> This call can be moved in `DynamicArchiveBuilder::iterate_roots`. That way, you don't need the dummy implementation of `StaticArchiveBuilder::iterate_primitive_array_klasses`.

Fixed

> src/hotspot/share/cds/archiveBuilder.cpp line 823:
> 
>> 821:   }
>> 822:   log_debug(cds)("Total array klasses gathered for dynamic archive: %d", DynamicArchive::num_array_klasses());
>> 823: }
> 
> This function can be put inside DynamicArchiveBuilder, since it's not used by the static dump.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14959#discussion_r1276679323
PR Review Comment: https://git.openjdk.org/jdk/pull/14959#discussion_r1276678251