RFR: 8309240: Array classes should be stored in dynamic CDS archive [v3]

[Coleen Phillimore]

On Thu, 27 Jul 2023 22:33:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @iklam comments
>
> src/hotspot/share/cds/dynamicArchive.cpp line 435:
> 
>> 433:       if (elm->is_instance_klass()) {
>> 434:         assert(InstanceKlass::cast(elm)->array_klasses() == nullptr, "must be");
>> 435:         InstanceKlass::cast(elm)->release_set_array_klasses(oak);
> 
> I know you were asked to use this here but a release operation only has meaning when paired with an acquire - so where is the matching acquire?

I don't know if this code is run at a safepoint, but because of this bug https://bugs.openjdk.org/browse/JDK-8308745, we can't use a lock to allocate objArrayKlass, so we'll likely need the matching acquire when we fix that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14959#discussion_r1276897034