RFR: 8309240: Array classes should be stored in dynamic CDS archive [v3]

[Calvin Cheung]

On Thu, 27 Jul 2023 23:16:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The code in question is being called during VM startup.
>> 
>> DynamicArchive::setup_array_klasses() : void
>> 	MetaspaceShared::initialize_shared_spaces() : void
>> 		universe_init() : jint
>> 			init_globals() : jint
>> 				Threads::create_vm(JavaVMInitArgs *, bool *) : jint
>> 					JNI_CreateJavaVM_inner(JavaVM * *, void * *, void *) : jint
>> 						JNI_CreateJavaVM(JavaVM * *, void * *, void *) : jint
>> 
>> Maybe it is safe not to use the "release_" version for setting `array_klasses`?
>
> The VM is still single-threaded at that point so no "release" is necessary in this code.

Thanks. There is no `set_array_klasses()` function yet. So I added one to instanceKlass.hpp in my latest commit https://github.com/openjdk/jdk/pull/14959/commits/6e69ba63cb01d0799d5609a0e72349d3659ef239.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14959#discussion_r1276946477