RFR: 8313249: Fix -Wconversion warnings in verifier code [v3]
Coleen Phillimore
coleenp at openjdk.org
Mon Jul 31 14:27:53 UTC 2023
On Mon, 31 Jul 2023 12:51:22 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> See bugid for comments. Most of the verifier code deals with ints, so the u2 and other parameters weren't really needed and can be promoted to int. Mostly types are changed, but a few checked_cast<>s are added.
>> Tested with tier1-4, sanity Oracle platforms.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Add static_cast
Yes, the old comment is dubious. Looking at frame_count, for instance, it's simply used as an int. It doesn't have any range check and it doesn't store anywhere. Since this code seems happy to use ints, I don't think there's a good reason to change this one to u2. I could remove the comment, or not.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15056#issuecomment-1658475658
More information about the hotspot-runtime-dev
mailing list