RFR: 8313249: Fix -Wconversion warnings in verifier code [v4]
Coleen Phillimore
coleenp at openjdk.org
Mon Jul 31 22:10:55 UTC 2023
On Mon, 31 Jul 2023 19:52:52 GMT, Dean Long <dlong at openjdk.org> wrote:
>> VerificationType's constructor is uintptr_t so int << 8 shouldn't overflow, should it? Although it might change sign, which we don't warn about. I'll change it and make its caller (bci's are passed and used as int everywhere even though they're u2), does a checked_cast<u2>.
>
> uintptr_t would be 32-bits on a 32-bit platform, right?
I keep forgetting there's 32 bits, ok.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15056#discussion_r1279929631
More information about the hotspot-runtime-dev
mailing list