RFR: 8308387: CLD created and unloading list sharing _next node pointer leads to concurrent YC missing CLD roots [v4]

Axel Boldt-Christmas aboldtch at openjdk.org
Thu Jun 1 06:17:30 UTC 2023


On Wed, 31 May 2023 20:40:39 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Spelling
>>  - Tidy up comment
>>  - Include unlink_next() in comment and remove whitespace
>
> src/hotspot/share/classfile/classLoaderDataGraph.cpp line 503:
> 
>> 501: 
>> 502:   for (ClassLoaderData* data = _head; data != nullptr; data = data->next()) {
>> 503:     if (data->is_alive()) {
> 
> There used to be more code for the case where data->is_alive() so this code had this continue, but you could simplify this by having an 'else' clause and remove the continue. That would clean this up a little.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14241#discussion_r1212627491


More information about the hotspot-runtime-dev mailing list