RFR: 8308764: Reporting errors from create_vm may crash [v2]

[Kim Barrett]

On Sat, 3 Jun 2023 11:25:55 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Changes per Coleen's suggestion.
>>  - Changes per Coleen's suggestion.
>>  - Merge branch 'master' into 8308764-create_vm_errors
>>  - Fix indentation
>>  - Merge branch 'master' into 8308764-create_vm_errors
>>  - Fixed typo
>>  - 8308764: Reporting errors from create_vm may crash
>
> src/hotspot/share/runtime/threads.cpp line 554:
> 
>> 552:       main_thread->smr_delete();
>> 553:     }
>> 554:     // Else don't delete main_thread as we need to report exceptions in the caller.
> 
> Is it really okay to just leak main_thread?  If the process is going to die anyway then sure, but I'm not sure
> that's true for all potential callers.  Of course, there's probably lots of other stuff getting leaked, so maybe
> it doesn't matter.

I see this was already discussed, with the same rationale for not caring about the leak.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14238#discussion_r1215504215