RFR: 8308764: Reporting errors from create_vm may crash [v2]

[David Holmes]

On Sat, 3 Jun 2023 11:27:33 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Changes per Coleen's suggestion.
>>  - Changes per Coleen's suggestion.
>>  - Merge branch 'master' into 8308764-create_vm_errors
>>  - Fix indentation
>>  - Merge branch 'master' into 8308764-create_vm_errors
>>  - Fixed typo
>>  - 8308764: Reporting errors from create_vm may crash
>
> src/hotspot/share/runtime/threads.cpp line 553:
> 
>> 551:     if (!main_thread->has_pending_exception()) {
>> 552:       main_thread->smr_delete();
>> 553:     }
> 
> We have the exact same problem below after the call to init_globals2 (very recently introduced by JDK-8240774).

Thanks @kimbarrett I had obviously missed that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14238#discussion_r1217278516