RFR: 8308764: Reporting errors from create_vm may crash [v3]

[David Holmes]

On Mon, 5 Jun 2023 00:23:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> There are more details in the bug report but the basic fix is to not delete the main_thread so that it is available to report the exception that caused VM initialization to fail. Added some additional comments too.
>> 
>> Testing:
>>  - basic fault injection to test non-exception exit paths both before and after Universe:;is_fully_initialized() which exercises the failing use of JavaThread::current()
>>  -  tiers 1-3 sanity testing
>> 
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply the same fix to init_globals2()

Take 3.

After the split of init_globals into two we only have the pending exception issue for the second one. As we only keep the main thread when there is a pending exception then we have to watch for a null thread before checking for exceptions. Removed additional commentary that could just cause confusion.

Please re-review @tstuefe , @coleenp , @kimbarrett - thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14238#issuecomment-1577860778