RFR: 8308764: Reporting errors from create_vm may crash [v4]

David Holmes dholmes at openjdk.org
Tue Jun 6 08:13:29 UTC 2023


On Tue, 6 Jun 2023 06:46:13 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Take 3
>
> src/hotspot/share/runtime/threads.cpp line 569:
> 
>> 567:     // It is possible that we managed to fully initialize Universe but have then
>> 568:     // failed by throwing an exception. In that case our caller JNI_CreateJavaVM
>> 569:     // we will want to report it, so we can't delete the main thread.
> 
> s/we//

Fixed - thanks Kim!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14238#discussion_r1219139502


More information about the hotspot-runtime-dev mailing list