RFR: 8308764: Reporting errors from create_vm may crash [v5]

[Coleen Phillimore]

On Tue, 6 Jun 2023 13:45:34 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comment typo
>
> src/hotspot/share/runtime/threads.cpp line 572:
> 
>> 570:     if (!main_thread->has_pending_exception()) {
>> 571:       main_thread->smr_delete();
>> 572:     }
> 
> I'm sorry for belaboring this change but since jni is the only caller of this and conditionally calls vm_exit_during_initialization() with the pending exception, why not just do it here and take out the code in jni?   I was confused for a while about the thread being null in the jni caller.

Also init_globals2 should have a better name, like init_objects_and_globals() or something like that.  But that's not this issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14238#discussion_r1219688467