RFR: 8308764: Reporting errors from create_vm may crash [v6]
David Holmes
dholmes at openjdk.org
Tue Jun 6 22:57:21 UTC 2023
> There are more details in the bug report but the basic fix is to not delete the main_thread so that it is available to report the exception that caused VM initialization to fail. Added some additional comments too.
>
> Testing:
> - basic fault injection to test non-exception exit paths both before and after Universe:;is_fully_initialized() which exercises the failing use of JavaThread::current()
> - tiers 1-3 sanity testing
>
> Thanks.
David Holmes has updated the pull request incrementally with one additional commit since the last revision:
Take 4: move the termination code into create_vm
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14238/files
- new: https://git.openjdk.org/jdk/pull/14238/files/884a1a33..8daa302e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14238&range=05
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14238&range=04-05
Stats: 21 lines in 2 files changed: 3 ins; 14 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/14238.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14238/head:pull/14238
PR: https://git.openjdk.org/jdk/pull/14238
More information about the hotspot-runtime-dev
mailing list