RFR: 8308764: Reporting errors from create_vm may crash [v5]

[David Holmes]

On Tue, 6 Jun 2023 22:27:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I agree that init_globals2 isn't a great name. I failed to come up with
>> something better, either now or when I added it.  Anyone with something better
>> should go for it.
>
> Sorry but this is getting a bit out of hand. Rearranging the deckchairs really doesn't change anything. You could argue that everything should happen in create_vm so JNI_CreateJavaVM is just a minimal wrapper, but that is not what fixing this issue is about. All I'm trying to do here is avoid the crash when there is no longer a current thread.

New version committed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14238#discussion_r1220498155