RFR: 8308764: Reporting errors from create_vm may crash [v6]

[David Holmes]

On Tue, 6 Jun 2023 22:57:21 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> There are more details in the bug report but the basic fix is to not delete the main_thread so that it is available to report the exception that caused VM initialization to fail. Added some additional comments too.
>> 
>> Testing:
>>  - basic fault injection to test non-exception exit paths both before and after Universe:;is_fully_initialized() which exercises the failing use of JavaThread::current()
>>  -  tiers 1-3 sanity testing
>> 
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Take 4: move the termination code into create_vm

Scratch take 4. You can't just move the exception handling into create_vm at that location because there are other places after that which can throw exceptions. Trying to revert to version 3 but I think I messed up my repo. <sigh>

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14238#issuecomment-1579655111