RFR: 8308764: Reporting errors from create_vm may crash [v7]

[Kim Barrett]

On Wed, 7 Jun 2023 00:43:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> There are more details in the bug report but the basic fix is to not delete the main_thread so that it is available to report the exception that caused VM initialization to fail. Added some additional comments too.
>> 
>> Testing:
>>  - basic fault injection to test non-exception exit paths both before and after Universe:;is_fully_initialized() which exercises the failing use of JavaThread::current()
>>  -  tiers 1-3 sanity testing
>> 
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert "Take 4: move the termination code into create_vm"
>   
>   This reverts commit 8daa302e5db87d54b85d8b4ef992c429fa4c03c6.

Marked as reviewed by kbarrett (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14238#pullrequestreview-1466917179