RFR: JDK-8303549: [AIX] TestNativeStack.java is failing with exit value 1 [v4]

Varada M duke at openjdk.org
Wed Jun 7 09:11:10 UTC 2023


On Wed, 7 Jun 2023 02:09:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Varada M has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Added pthread_attr_destroy
>>  - Added pthread_attr_destroy
>
> test/hotspot/jtreg/runtime/jni/getCreatedJavaVMs/exeGetCreatedJavaVMs.c line 109:
> 
>> 107:       printf("pthread_attr_destroy failed: %d - %d\n", i, status);
>> 108:       exit(-1);
>> 109:     }
> 
> Nit: `pthread_attr_destroy` has no specified failure modes. We never check its return value elsewhere in the OpenJDK code.

I have removed the error check.

Thank you

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14209#discussion_r1221212906


More information about the hotspot-runtime-dev mailing list