RFR: 8308764: Reporting errors from create_vm may crash [v7]

David Holmes dholmes at openjdk.org
Wed Jun 7 09:14:57 UTC 2023


On Wed, 7 Jun 2023 08:47:50 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert "Take 4: move the termination code into create_vm"
>>   
>>   This reverts commit 8daa302e5db87d54b85d8b4ef992c429fa4c03c6.
>
> Okay.
> 
> I preferred the old solution, since if an error happens at initialization, I like the JVM to stop as fast as possible. Going through smr_delete seems superfluous, and the leak not really important, since we leak a lot of other stuff anyway.

Thanks @tstuefe ! This solution is kind of minimalistic in that it only preserves the main-thread when we know there is an exception pending.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14238#issuecomment-1580267493


More information about the hotspot-runtime-dev mailing list