RFR: JDK-8303549: [AIX] TestNativeStack.java is failing with exit value 1 [v5]
Varada M
duke at openjdk.org
Wed Jun 7 11:38:29 UTC 2023
On Wed, 7 Jun 2023 09:15:06 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed error check for pthread_attr_destroy(&attr)
>
> test/hotspot/jtreg/runtime/jni/getCreatedJavaVMs/exeGetCreatedJavaVMs.c line 97:
>
>> 95: pthread_attr_init(&attr);
>> 96: size_t stack_size = 0x100000;
>> 97: pthread_attr_setstacksize(&attr, stack_size);
>
> Sorry I hate to do this but Just realized that the `pthread-attr` stuff doesn't need to be done on each loop iteration - one attr object can be used for all the threads - and so can be moved outside the loop. Thanks.
Thank you @dholmes-ora for pointing that out. I have updated it
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14209#discussion_r1221423749
More information about the hotspot-runtime-dev
mailing list