RFR: 8299825: Move StdoutLog and StderrLog to LogConfiguration

[David Holmes]

On Thu, 8 Jun 2023 12:11:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi,
>> 
>> Please consider this small cleanup. `LogConfiguration` initializes and handles the lifetime of `StdoutLog` and `StderrLog`, therefore they should logically belong to that class. I leave the visibility as public for the time being, to change it to private would require the gtests to all be part of a fixture.
>
> src/hotspot/share/logging/logConfiguration.cpp line 47:
> 
>> 45: 
>> 46: LogStdoutOutput* LogConfiguration::LogConfiguration::StdoutLog = nullptr;
>> 47: LogStderrOutput* LogConfiguration::LogConfiguration::StderrLog = nullptr;
> 
> Why is `LogConfiguration` given twice?

I'm going to guess after you made the initial change you did a global replace that added `LogConfiguration::` to every occurrence of the names - many of which are not needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14376#discussion_r1222956449