RFR: 8299825: Move StdoutLog and StderrLog to LogConfiguration [v2]
David Holmes
dholmes at openjdk.org
Fri Jun 9 02:01:52 UTC 2023
On Thu, 8 Jun 2023 12:51:56 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Hi,
>>
>> Please consider this small cleanup. `LogConfiguration` initializes and handles the lifetime of `StdoutLog` and `StderrLog`, therefore they should logically belong to that class. I leave the visibility as public for the time being, to change it to private would require the gtests to all be part of a fixture.
>
> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove from header
> - Fixes
Updates look good - much simpler.
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14376#pullrequestreview-1471067803
More information about the hotspot-runtime-dev
mailing list