RFR: 8308463: Refactor regenerated class handling in lambdaFormInvokers.cpp

David Holmes dholmes at openjdk.org
Wed Jun 21 06:38:09 UTC 2023


On Wed, 21 Jun 2023 00:00:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> The handling of regenerated classes need to be refactored to enable future development:
> 
> - Improve the API to access the regenerated classes and their methods
> - Allow more classes to be regenerated, not just the Lambda Form invokers. Therefore, the code is moved to a new file cds/regeneratedClasses.cpp
> 
> 
> Please see the bug report [JDK-8308463](https://bugs.openjdk.org/browse/JDK-8308463) for motivation of this PR.

First pass looks reasonable. Unclear on some of the details.

Thanks.

src/hotspot/share/cds/regeneratedClasses.hpp line 34:

> 32: #include "utilities/resourceHash.hpp"
> 33: 
> 34: class RegeneratedClasses : public AllStatic {

Please add a class comment describing what RegeneratedClasses are.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14573#pullrequestreview-1489860840
PR Review Comment: https://git.openjdk.org/jdk/pull/14573#discussion_r1236444923


More information about the hotspot-runtime-dev mailing list