Integrated: 8310297: assert(static_cast<T1>(result) == thing) with ctw

Coleen Phillimore coleenp at openjdk.org
Wed Jun 21 11:49:18 UTC 2023


On Tue, 20 Jun 2023 20:05:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> checked_cast<> doesn't work with the initializers in classfiles because even though javac will complain like:
> 
> ByteFieldInitTest.java:32: error: incompatible types: possible lossy conversion from int to byte
>     static byte b = 0x80;
>                     ^
> 1 error
> 
> classfiles can have this value and we've always treated this as a negative signed value.  Removed the checked_cast for javaClasses static final initializers.
> 
> Tested with tier1 on all platforms and added a test.

This pull request has now been integrated.

Changeset: 70e1c92a
Author:    Coleen Phillimore <coleenp at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/70e1c92a7f1b5450058a2dd7dbdf9d88eb85e970
Stats:     97 lines in 3 files changed: 93 ins; 0 del; 4 mod

8310297: assert(static_cast<T1>(result) == thing) with ctw

Reviewed-by: iklam, dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/14571


More information about the hotspot-runtime-dev mailing list