RFR: 8308463: Refactor regenerated class handling in lambdaFormInvokers.cpp [v2]

[Coleen Phillimore]

On Thu, 22 Jun 2023 03:46:28 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/cds/regeneratedClasses.cpp line 75:
>> 
>>> 73: 
>>> 74: void RegeneratedClasses::record_regenerated_objects() {
>>> 75:   if (_renegerated_objs != nullptr) {
>> 
>> Does the DumpTimeTable_lock protect regenerated_objs also?
>
> This function is called inside a safepoint and can't lock  DumpTimeTable_lock. I added `assert(SafepointSynchronize::is_at_safepoint()` instead.

assert_locked_or_safepoint(DumpTimeTable_lock) might be better in case you someday don't dump during safepoint.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14573#discussion_r1238925911