RFR: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V

Robbin Ehn rehn at openjdk.org
Mon Jun 26 10:03:01 UTC 2023


On Mon, 26 Jun 2023 09:16:53 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> The `Platform.isRISCV64()` check was once added in our internal development. The reason was that we have different C Frame and Java Frame layouts at first. So we could not get the right stacks without the RISC-V specific `get_native_stack`. After defining RISC-V related `get_native_stack` method (refactored by https://github.com/openjdk/jdk-sandbox/commit/db2415748747a0912749bb8fc160a8948021a924), it could return the expected symbols. So we can remove the platform check for RISC-V safely.
> 
> runtime/NMT/CheckForProperDetailStackTrace.java still passed without `Platform.isRISCV64()` check.
> 
> Testing:
> - [x] fastdebug  build (cross/native compile)
> - [x] release  build (cross/native compile)

Thank you, ship it!

-------------

Marked as reviewed by rehn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14650#pullrequestreview-1498130725


More information about the hotspot-runtime-dev mailing list