RFR: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V

[Feilong Jiang]

On Mon, 26 Jun 2023 09:46:58 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> The `Platform.isRISCV64()` check was once added in our internal development. The reason was that we have different C Frame and Java Frame layouts at first. So we could not get the right stacks without the RISC-V specific `get_native_stack`. After defining RISC-V related `get_native_stack` method (refactored by https://github.com/openjdk/jdk-sandbox/commit/db2415748747a0912749bb8fc160a8948021a924), it could return the expected symbols. So we can remove the platform check for RISC-V safely.
>> 
>> runtime/NMT/CheckForProperDetailStackTrace.java still passed without `Platform.isRISCV64()` check.
>> 
>> Testing:
>> - [x] fastdebug  build (cross/native compile)
>> - [x] release  build (cross/native compile)
>
> Happy to see this platform-specific check removed. Seems that we missed it when refactoring the frame layout for RISC-V.

@RealFYang @robehn -- Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14650#issuecomment-1608537721