RFR: 8310920: Fix -Wconversion warnings in command line flags [v2]

[David Holmes]

On Tue, 27 Jun 2023 12:51:16 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is broken out from but tested with the PR from https://github.com/openjdk/jdk/pull/14659
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make phase parameter JVMFlagConstraintPhase and fix another double/float conversion.

Phase changes look good - thanks!

One minor nit below but approved.

src/hotspot/share/runtime/flags/jvmFlag.cpp line 582:

> 580: 
> 581: JVMFlag* JVMFlag::fuzzy_match(const char* name, size_t length, bool allow_locked) {
> 582:   double VMOptionsFuzzyMatchSimilarity = 0.7f;

You don't want the 'f' on `0.7f` now

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14665#pullrequestreview-1501992492
PR Review Comment: https://git.openjdk.org/jdk/pull/14665#discussion_r1244475966