RFR: 8310974: NMT: Arena diffs miss the scale

[Aleksey Shipilev]

On Tue, 27 Jun 2023 17:29:53 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> We noticed this in one of the NMT logs:
>> 
>> 
>> Compiler (reserved=175324KB +135838KB, committed=175324KB +135838KB)
>>     (malloc=29999KB +5558KB #23578 +8965)
>>     (arena=145325KB +130279 #17 -5)
>> 
>> 
>> The +130279 should actually be +130279KB. 
>> 
>> I looked at all current uses of `diff_in_current_scale` and `amount_in_current_scale`, and all them seem to be printed with scale. So we have only this one spot missing.
>> 
>> Note this also fixes the stray `d` leftover from [JDK-8281213](https://bugs.openjdk.org/browse/JDK-8281213).
>> 
>> Sample excerpt before:
>> 
>> 
>> -                  Compiler (reserved=1623KB +453KB, committed=1623KB +453KB)
>>                             (malloc=16KB +1KB #110 +19)
>>                             (arena=1608KB +452d #10 +5)
>> 
>> 
>> ...and after:
>> 
>> 
>> -                  Compiler (reserved=220KB -537KB, committed=220KB -537KB)
>>                             (malloc=25KB +8KB #228 +110)
>>                             (arena=196KB -546KB #4 -1)
>> 
>> 
>> Additional testing:
>>  - [x] macos-aarch64-server-fastdebug, `runtime/NMT`
>
> LGTM

Thanks, @zhengyu123! Anyone else wants to take a look? @tstuefe, perhaps?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14680#issuecomment-1611270629