RFR: JDK-8310919: runtime/ErrorHandling/TestAbortVmOnException.java times out due to core dumps taking a long time on OSX [v2]

Tobias Hartmann thartmann at openjdk.org
Thu Jun 29 11:11:55 UTC 2023


On Thu, 29 Jun 2023 11:07:09 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> Sometimes the test `runtime/ErrorHandling/TestAbortVmOnException.java` times out on MacOS.
>> 
>> This is due to the fact that the test crashes 3 times by design creating a core dump every time and sometimes on MacOS it takes a long time to create core dumps.
>> 
>> Since there is no reason for these crashes to have core dumps, we avoid creating them by using the `-XX:-CreateCoredumpOnCrash` flag.
>> 
>> Additionally adding `-XX:CompileCommand=compileonly,TestAbortVmOnException::*` to restrict the compilation only to `TestAbortVmOnException` methods and thus make the test faster.
>
> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8310919: removing -Xbatch

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14704#pullrequestreview-1505057940


More information about the hotspot-runtime-dev mailing list