RFR: 8311145: Remove check_with_errno duplicates
Robbin Ehn
rehn at openjdk.org
Fri Jun 30 18:34:53 UTC 2023
On Fri, 30 Jun 2023 17:35:45 GMT, Daohan Qu <dqu at openjdk.org> wrote:
>> Looks good, thanks.
>
> Thanks for your review, @robehn !
@quadhier hotspot changes use two reviewers, one with capital R (i.e. reviewer status on census) and a second reviewer (which may be e.g. a comitter).
You find the info here:
https://openjdk.org/guide/#contributing-to-an-openjdk-project
"At least one reviewer should be knowledgeable in the area being changed. Some areas (e.g. client and hotspot) require two reviewers in most cases, so be sure to read the relevant OpenJDK group pages for advice or ask your sponsor."
@tstuefe is this what you had in mind?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14733#issuecomment-1615040328
More information about the hotspot-runtime-dev
mailing list